First of all, I have the iPhone XS, not the 12, but this is to share a few thoughts: a) the phone I was the happiest with was the 7 Plus. -- the larger size and features just made for a fantastic camera. If your phone is your primary camera, this is a consideration. However, I downsized back down to the smaller size at my next phone upgrade, which I regret. b) on my most recent trip to Egypt, I exclusively used my phone as camera and I wished I had a better camera (First World Problems, I realize). I used my phone exclusively in part due to the compressed amount of time we had at each site on each day and trying to soak it all in but also because it's easier to organize and upload pictures from your phone, unless you have a serious process and a more serious photography game than I do (I am quite basic). If you are in this same position, I would consider upgrading before a significant international trip, with sufficient time to iron out the kinks before you go (don't forget to get an unlocked phone so you can get a local SIM). Having the best/latest camera possible, within reason, is something to take into consideration. I will be purchasing the Max size from now on and will be paying more attention to the quality of the camera on my phone in sync with international trips.