Our three kids have been through a lot of toys in my house. Honestly, most of them are junk. Poorly made plastic that barely survives unboxing and then rots in a drawer for a year or two before getting donated. Most of it comes from grandparents.
Only two toys have withstood the test of time - Legos and Magna Tiles. Both toys share that combination of durability and creativity.
Magna Tiles are thick plastic shapes with magnets inside. Snap 'em together to craft little buildings or other structures. They come in a variety of colors and shapes, mostly squares and triangles.
This toy is indestructible, and each of my kids has spent several years playing with the tiles. We always find an excuse to keep the Magna Tiles because the kids still use them.